Skip to content

try enabling ALCTest in GCStress again. #117388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2025
Merged

try enabling ALCTest in GCStress again. #117388

merged 2 commits into from
Jul 10, 2025

Conversation

@mangod9
Copy link
Member

@mangod9 mangod9 commented Jul 7, 2025

Fixes #106241

Copilot AI review requested due to automatic review settings July 7, 2025 19:58
Copilot AI reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Re-enables the ALCTest unit test under GCStress by removing the flag that marked it as incompatible.

  • Deleted the <GCStressIncompatible>true</GCStressIncompatible> property to allow the test to run under GCStress.
  • Removed the accompanying comment that temporarily disabled GCStress support.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 7, 2025
@mangod9
Copy link
Member Author

mangod9 commented Jul 7, 2025

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

azure-pipelines bot commented Jul 7, 2025

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Jul 8, 2025
Open
Closed
Closed
Closed
@mangod9
Copy link
Member Author

mangod9 commented Jul 8, 2025

Looks like the ALCTest is passing in the gcstress pipeline: https://helix.dot.net/api/jobs/69fc089e-cdde-4d81-a3eb-617da9772180/workitems/profiler.0.1/files/console.8131af21.log?api-version=2019-06-17.

@mdh1418, can you please confirm so we can get it enabled again. Thx.

mdh1418
mdh1418 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@mdh1418 mdh1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does look like the test passed on this CI run.
Just to note, the original failure seemed flakey, so unless somehow the underlying cause was fixed by some alternate change, it might just be reopened again later.

@mangod9
Copy link
Member Author

mangod9 commented Jul 9, 2025

Ok, let's enable for now and determine if it fails again and we can investigate at that time.

@mangod9 mangod9 merged commit 5be07dc into dotnet:main Jul 10, 2025
72 of 74 checks passed
@mangod9 mangod9 deleted the enable_alc_stress branch July 10, 2025 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@mdh1418 mdh1418 mdh1418 approved these changes

Assignees

@mangod9 mangod9

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Test failure: profiler\\assembly\\ALCTest\\ALCTest.cmd

2 participants

@mangod9 @mdh1418